Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "every component" block #2452

Merged
merged 18 commits into from Feb 4, 2023
Merged

Add "every component" block #2452

merged 18 commits into from Feb 4, 2023

Conversation

Vishwas-Adiga
Copy link
Member

This PR adds an "every component" block that returns a list of all components of a given type.
See this community topic for more context.

Screenshots:
image
image

@ewpatton ewpatton requested a review from a team March 29, 2021 12:28
@ewpatton ewpatton self-assigned this Mar 29, 2021
@ewpatton
Copy link
Member

@Vishwas-Adiga This is a good start, but since it changes the blocks that are available in the companion, you should rebase the change onto ucr, bump the BLOCKS_LANGUAGE_VERSION in YaVersion, and add an upgrade path in versioning.js. From a design perspective, what other designs did you consider and why do you think this approach is the best option?

@Vishwas-Adiga
Copy link
Member Author

Thanks for the pointers, @ewpatton . I'll make the required changes this weekend

I'll also try and link to a design document outlining how I came to this block design for the required functionality, if such an arrangement works for you?

@ewpatton
Copy link
Member

@Vishwas-Adiga Yes that's fine.

@Vishwas-Adiga Vishwas-Adiga changed the base branch from master to ucr April 5, 2021 15:39
@Vishwas-Adiga Vishwas-Adiga changed the base branch from ucr to master April 5, 2021 15:40
@Vishwas-Adiga Vishwas-Adiga changed the base branch from master to ucr April 5, 2021 15:46
@Vishwas-Adiga Vishwas-Adiga changed the base branch from ucr to master April 5, 2021 15:52
@Vishwas-Adiga Vishwas-Adiga changed the base branch from master to ucr April 5, 2021 15:52
ewpatton
ewpatton requested changes May 14, 2021
View reviewed changes
Copy link
Member

@ewpatton ewpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwas-Adiga. This looks pretty good. Please merge ucr to pick up @BeksOmega's changes and there are a few minor things to address, but otherwise this looks pretty good to me.

appinventor/blocklyeditor/src/blocks/components.js Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/blocks/components.js Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/blocks/components.js Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/blocks/components.js Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/blocks/components.js Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/component_database.js Outdated Show resolved Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/util/ComponentUtil.java Outdated Show resolved Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/util/ComponentUtil.java Outdated Show resolved Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/util/ComponentUtil.java Outdated Show resolved Hide resolved
appinventor/blocklyeditor/src/generators/yail/componentblock.js Outdated Show resolved Hide resolved
@ewpatton ewpatton added this to the nb187 milestone May 14, 2021
@ewpatton
Copy link
Member

@Vishwas-Adiga Do you want to go ahead and update this with ucr? I would like to merge this PR next.

@Vishwas-Adiga
Copy link
Member Author

Sorry, I've been unable to work on this lately. I'll work on the style changes and bring the branch up to date right away

@ewpatton ewpatton removed this from the nb187 milestone Aug 4, 2021
@ewpatton ewpatton added this to the nb189 milestone Nov 22, 2021
@ewpatton ewpatton modified the milestones: nb189, nb190 May 10, 2022
@ewpatton ewpatton modified the milestones: nb190, nb191 Sep 13, 2022
@ewpatton
Merge remote-tracking branch 'github/ucr' into HEAD
a707668 
Change-Id: I58f6a35cb9dc3ded9d6217836d51e677fbba0842
@ewpatton
Fix versioning comment for 'every component' block
7981f12 
Change-Id: Ic9c0034c77584a7593b2b8e48dd31476762d0e8e
@ewpatton ewpatton merged commit a721e95 into mit-cml:ucr Feb 4, 2023
fturbak pushed a commit to fturbak/appinventor-sources that referenced this pull request Aug 10, 2023
@Vishwas-Adiga @fturbak
Add "every component" block (mit-cml#2452)
77a7083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewpatton ewpatton ewpatton approved these changes

Assignees

@ewpatton ewpatton

Labels
affects: ucr feature request pull request: needs review
Projects
None yet
Milestone
nb191
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vishwas-Adiga @ewpatton